Update dependencies, use Laminas Diactoros, ~update signature for Encoder::_doRequest
and Decoder::_doRequest
~
#62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thank you so much for ReactPHP and ReactPHP-Soap! I am using both in a small project and bring a very nice improvement in performance.
I noticed that:
I went ahead and tried to address these observations:
Looking forward to your feedback!
EDIT: Since promises aims to support older PHP versions, I am dropping the
_doRequest
signature update to not break compatibility with PHP<8.0