Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Bumps the rust edition to 2024.
Summary of changes
I just ran
cargo fix --edition
for 2024, and there were very few changes needed.Rationale
This isn't just about being stale, this would make writing the rule engine SO MUCH easier. Notably async closures would help quite a lot with all of the continuations in the rule engine (the verbosity right now makes it hard to grok). There is basically no hope for someone trying to contribute to the rule engine who doesn't understand how futures in Rust works...
Also once this gets stabilized things become so much nicer: rust-lang/rust#138424 (it would mean we don't have to have the
UnitFuture
type alias andBox::pin
all of our continuations with thedyn Trait
coercions).