Mock covidcast/meta requests.get call #1470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added mock for requests.get function. Made sure that signals that are inactive have the 'active' tag as False, which in turn affects whether it is a valid geo_signal combo.
|
Do I need to cite code I take from stackexchange? Is there some kind of procedure for this? |
nmdefries
approved these changes
Jan 19, 2022
Comment on lines
+24
to
+25
| # Solution from https://stackoverflow.com/questions/15753390/ | ||
| #how-can-i-mock-requests-and-the-response |
There was a problem hiding this comment.
Yeah, linking to where you found a solution is fine, especially if the approach is tricky or complex or non-standard in some way. You can also link to explanations of bugs for larger or more complex bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added mock for requests.get function.
Made sure that signals that are inactive have the 'active' tag as False, which in turn affects whether it is a valid geo_signal combo.
Changelog
Fixes
get_geo_signal_combos#1456