Add key for Ryan N #974
Merged
Add key for Ryan N #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cmu-delphi-main ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
melange396
reviewed
May 28, 2024
content/people/index.md
Outdated
| @@ -600,7 +600,8 @@ people: | |||
| affiliation: Stanford University | |||
| team: | |||
| - core | |||
| - firstName: Ryan | |||
| - key: ryan-n | |||
There was a problem hiding this comment.
its probably fine, but im not in love with the hyphen being in there... can we use his andrew id instead?
Suggested change
| - key: ryan-n | |
| - key: rnayebi |
once this PR is done, im going to create a GH issue to try to ensure that name collisions like this dont happen again, and one way to accomplish that is to use andrew IDs which are already unique.
melange396
approved these changes
May 28, 2024
melange396
pushed a commit
that referenced
this pull request
May 29, 2024
* Add key for Ryan N * Update Ryan T's website URL
melange396
added a commit
that referenced
this pull request
May 29, 2024
* Add key for Ryan N (#974) * Update Ryan T's website URL * chore: release v3.2.16 --------- Co-authored-by: Carlyn Van Dyke <[email protected]> Co-authored-by: melange396 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve two-Ryan-problem