Skip to content

Add Lima artwork #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Add Lima artwork #361

merged 1 commit into from
Oct 4, 2022

Conversation

AkihiroSuda
Copy link
Contributor

Lima was approved as a CNCF Sandbox project recently

@AkihiroSuda
Copy link
Contributor Author

cc @jandubois @mattfarina

@lukaszgryglicki
Copy link
Member

This PR is not following naming conventions used in other projects and is not providing both PNG and SVG files.

@AkihiroSuda
Copy link
Contributor Author

This PR is not following naming conventions used in other projects and is not providing both PNG and SVG files.

Fixed

Copy link
Member

@lukaszgryglicki lukaszgryglicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This misses standard icon/color artwork, only horizontal is present - please see other projects and create similar files.

@AkihiroSuda
Copy link
Contributor Author

This misses standard icon/color artwork, only horizontal is present - please see other projects and create similar files.

Is this a blocker for onboarding?
ORAS and Konveyor seem to lack the icon/color artwork too.

If it is a blocker, is it ok to just reuse the horizontal logo as the icon? (just as in TiKV, gRPC, and OpenYurt)

@lukaszgryglicki
Copy link
Member

Not a blocker. I just mentioned this because DevStats uses icon/color ones.

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
Copy link
Contributor Author

Rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants