tracing: add execution tracing #138013
Draft
tracing: add execution tracing #138013
+189
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
andrewbaptist
force-pushed
the
2024-12-26-flight-recorder
branch
from
28602c6 to
51a1a72
Compare
This commit adds the ability to capture execution traces from the past few seconds of execution when something seems wrong. Often when a timer fires and we detect something is wrong, the relevant information is already lost. The new flight recorder in go golang/go#63185 creates a ring buffer that enables capturing these traces. This commit adds the capability to capture traces but doesn't enable it anywhere. There is a small performance cost of having the flight recorder always enabled, so some performance testing is required to determine if we need to protect this behind a cluster setting. Epic: none Release note: None
We have seen a number of slow local responses which appear due to slow fsyncs, however it is not clear if this is happening in our process our outside. This commit adds flight recorder snapshotting when we see a slow response. Epic: none Release note: None
andrewbaptist
force-pushed
the
2024-12-26-flight-recorder
branch
from
51a1a72 to
915355a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to capture execution traces from the past
few seconds of execution when something seems wrong. Often when a timer
fires and we detect something is wrong, the relevant information is
already lost. The new flight recorder in go
golang/go#63185 creates a ring buffer that
enables capturing these traces. This commit adds the capability to
capture traces but doesn't enable it anywhere.
There is a small performance cost of having the flight recorder always
enabled, so some performance testing is required to determine if we need
to protect this behind a cluster setting.
Epic: none
Release note: None