-
Notifications
You must be signed in to change notification settings - Fork 470
DOC-11438 Docs for cc/console: Grouping clusters by labels #19484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
In redirects.yml, added entry for cluster-management-advanced.md to advanced-cluster-management.
…sic and not Advanced. In authorization.md, in Cluster Operator section added link to Manage Labels. In billing-management.md, in View Credits balance section added link to Manage Labels. In releases/cloud.md, add release note for Manage Labels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @florence-crl! I left some feedback inline. A couple of things:
- Could we include a quick overview of the feature with some example uses?
- Can we include info on roles required to manage labels?
- You can label both clusters and folders
- There are rules/requirements for the labels you can use (like character limits, and things like that)
added link to labels.md to: *cluster-management.md authorization.md, in Cluster Operator section folder-admin include file billing-management.md, in View Credits balance section. cloud-deployments.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Florence! Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great as-is, but I've made some suggestions for your consideration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TFTRs
Fixes DOC-11438
Added labels.md.
Added link to labels.md to:
In releases/cloud.md, added release note for labels.
In cluster-overview-page.md, added labels to settings for Standard/Basic and not Advanced.
In cluster-management.md include file, fixed html_page_filenames list so that filter tabs appear.
Deleted cluster-management-advanced.md.
In redirects.yml, added entry for cluster-management-advanced.md to advanced-cluster-management.
Rendered previews