-
Notifications
You must be signed in to change notification settings - Fork 469
Add docs for CREATE TABLE ... AS OF SYSTEM TIME
#19674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
bf54120
to
6b1ca8c
Compare
0c99b3d
to
a8f42f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes lgtm!
i wasn't sure if @dikshant also wanted to have CREATE MATERIALIZED VIEW ... AS OF SYSTEM TIME
documented. i'll leave that decision to him.
Yeah we also want the materialized view part to be documented. But I'll leave it to Rich to decide if he wants to do that in this PR or a new one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM but One more example that I think we should add!
I'll do it in another PR! would rather get this smaller one now in so folks can start using this ASAP |
Fixes DOC-13310