Skip to content

Add docs for CREATE TABLE ... AS OF SYSTEM TIME #19674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rmloveland
Copy link
Contributor

Fixes DOC-13310

@rmloveland rmloveland marked this pull request as draft May 29, 2025 20:45
Copy link

netlify bot commented May 29, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit a37be22
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/68473e28342bbb000857e41f

Copy link

github-actions bot commented May 29, 2025

Copy link

netlify bot commented May 29, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit a37be22
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/68473e28a4bfb600080379a5

Copy link

netlify bot commented May 29, 2025

Netlify Preview

Name Link
🔨 Latest commit a37be22
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/68473e2885ac8d0008d09835
😎 Deploy Preview https://deploy-preview-19674--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rmloveland rmloveland force-pushed the 20250529-DOC-13310-ctas-aost branch 3 times, most recently from bf54120 to 6b1ca8c Compare June 4, 2025 17:49
@rmloveland rmloveland force-pushed the 20250529-DOC-13310-ctas-aost branch from 0c99b3d to a8f42f6 Compare June 4, 2025 19:03
@rmloveland rmloveland marked this pull request as ready for review June 4, 2025 19:12
@rmloveland rmloveland requested review from rafiss and dikshant June 4, 2025 19:13
Copy link
Contributor

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes lgtm!

i wasn't sure if @dikshant also wanted to have CREATE MATERIALIZED VIEW ... AS OF SYSTEM TIME documented. i'll leave that decision to him.

@dikshant
Copy link

dikshant commented Jun 9, 2025

Yeah we also want the materialized view part to be documented. But I'll leave it to Rich to decide if he wants to do that in this PR or a new one.

Copy link

@dikshant dikshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM but One more example that I think we should add!

@rmloveland rmloveland requested a review from taroface June 9, 2025 20:04
@rmloveland
Copy link
Contributor Author

Yeah we also want the materialized view part to be documented. But I'll leave it to Rich to decide if he wants to do that in this PR or a new one.

I'll do it in another PR! would rather get this smaller one now in so folks can start using this ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants