Update user #300
Update user #300
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
src/code42cli/cmds/users.py
Outdated
| @sdk_options() | ||
| def bulk_update(state, csv_rows, format): | ||
| """Update a list of users from the provided CSV.""" | ||
| csv_rows[0]["updated"] = False |
There was a problem hiding this comment.
Why do we need this line csv_rows[0]["updated"] = False?
What happens if someone passes in a csv with no rows, does this through some IndexError?
^ if that is the case, and this is needed, we should check the length first and fail early with a better error
There was a problem hiding this comment.
This is to add the column, for some reason if we don't add it beforehand, the addition during handle_row wasn't working properly. I copied this approach from how devices bulk deactivate does it.
The CSV is validated by read_csv(), which will raise an error if the CSV does not contain the proper rows.
|
In |
| def test_update_user_calls_update_user_with_correct_parameters( | ||
| runner, cli_state, update_user_success | ||
| ): | ||
| command = ["users", "update", "--user-id", "12345", "--email", "test_email"] |
There was a problem hiding this comment.
Can you include all the args here so the test confirms they all get passed to the right spot?
There was a problem hiding this comment.
I wanted to test also that it properly passed None where no argument was given (since we don't want the method to accidentally update all unchanged fields to blank values). I've added additional tests to validate that all parameters are passed properly.
…dated" column in devices bulk update; more comprehensive tests
…deactivated" column
Sure, I'll do that now. |
Description of Change
This change adds a method
code42 users updateto update a single user, and the corresponding bulk methodcode42 users bulk updateIt partially addresses (but does not fully address) issue #259
Testing Procedure
PR Checklist