forked from demisto/content
-
Notifications
You must be signed in to change notification settings - Fork 0
Filter type param #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
10983c1
Add search alert command
7000efb
Save progress
4affd1b
Rename
f54c3b6
Rename
4aa3791
Test alert search command
3d50bd0
Handle getting only top x number
515e438
ignore 0
c7dca90
Fix cl
d38b5e9
Fix cl
b84049f
Remove whitespace in yml
6f7ebc5
Gen yml
7528838
Main
4af651b
Tags
cff5ae4
Merge
7da6aac
Save
75c0eb6
Merge branch 'download-file' into de-widget
6f17942
hr last 30 days
cc5ff95
Save
0c1ad74
Merge branch 'download-file' into de-widget
4b46489
Remove paid content
c68202b
Update search alerts
b8f7dd5
Test
dfd4fd3
Filter type param to de get all
8e79753
Remove alert search from pr
27a2f13
Remove readme changes
c39dcb6
Remove unused import
ee28be3
Merge branch 'master' into de-widget
cfded62
Add leaving today option
8ad02ca
Default value enforcements
9b27bd7
Merge branch 'master' into de-widget
8fc1388
Put back?
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -361,45 +361,43 @@ | |
"type$": "ALERT_SUMMARY", | ||
"tenantId": "1d700000-af5b-4231-9d8e-df6434d00000", | ||
"type": "FED_ENDPOINT_EXFILTRATION", | ||
"name": "Exposure on an endpoint", | ||
"description": "This default rule alerts you when departing employees move data from an endpoint.", | ||
"actor": "test.testerson@example.com", | ||
"name": "Departing Employee Alert", | ||
"description": "Cortex XSOAR is cool.", | ||
"actor": "user1@example.com", | ||
"target": "N/A", | ||
"severity": "HIGH", | ||
"ruleId": "9befe477-3487-40b7-89a6-bbcced4cf1fe", | ||
"ruleSource": "Departing Employee", | ||
"id": "fbeaabc1-9205-4620-ad53-95d0633429a3", | ||
"createdAt": "2020-05-04T20:46:45.8106280Z", | ||
"id": "36fb8ca5-0533-4d25-9763-e09d35d60610", | ||
"createdAt": "2019-10-02T17:02:23.5867670Z", | ||
"state": "OPEN" | ||
}, | ||
{ | ||
"type$": "ALERT_SUMMARY", | ||
"tenantId": "1d700000-af5b-4231-9d8e-df6434d00000", | ||
"type": "FED_ENDPOINT_EXFILTRATION", | ||
"name": "Exposure on an endpoint", | ||
"description": "This default rule alerts you when departing employees move data from an endpoint.", | ||
"actor": "[email protected]", | ||
"type": "FED_CLOUD_SHARE_PERMISSIONS", | ||
"name": "High-Risk Employee Alert", | ||
"actor": "[email protected]", | ||
"target": "N/A", | ||
"severity": "LOW", | ||
"severity": "MEDIUM", | ||
"ruleId": "9befe477-3487-40b7-89a6-bbcced4cf1fe", | ||
"ruleSource": "Departing Employee", | ||
"id": "6bb7ca1e-c8cf-447d-a732-9652869e42d0", | ||
"createdAt": "2020-05-04T20:35:54.2400240Z", | ||
"id": "18ac641d-7d9c-4d37-a48f-c89396c07d03", | ||
"createdAt": "2019-10-02T17:02:24.2071980Z", | ||
"state": "OPEN" | ||
}, | ||
{ | ||
"type$": "ALERT_SUMMARY", | ||
"tenantId": "1d700000-af5b-4231-9d8e-df6434d00000", | ||
"type": "FED_ENDPOINT_EXFILTRATION", | ||
"name": "Exposure on an endpoint", | ||
"description": "This default rule alerts you when departing employees move data from an endpoint.", | ||
"actor": "[email protected]", | ||
"name": "Custom Alert 1", | ||
"actor": "[email protected]", | ||
"target": "N/A", | ||
"severity": "HIGH", | ||
"severity": "LOW", | ||
"ruleId": "9befe477-3487-40b7-89a6-bbcced4cf1fe", | ||
"ruleSource": "Departing Employee", | ||
"id": "c2c3aef3-8fd9-4e7a-a04e-16bec9e27625", | ||
"createdAt": "2020-05-04T20:19:34.7121300Z", | ||
"id": "3137ff1b-b824-42e4-a476-22bccdd8ddb8", | ||
"createdAt": "2019-10-02T17:03:28.2885720Z", | ||
"state": "OPEN" | ||
} | ||
], | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause
None
to be sent as the filter type if one isn't passed in, which would override the default value of"OPEN"
. We should setfilter_type
to"OPEN"
if it is falsy before calling this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the default value for the command is OPEN, but it is good to be double-y sure