V9.0.4/service update #12
Conversation
WalkthroughThis update revises dependency versions across multiple project files, updates Docker and test environment images, and modifies GitHub workflow configurations to use newer workflow versions and parameters. Additionally, release notes and changelogs are incremented to reflect a new service update focused on dependency upgrades. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHub Actions
participant External Workflow v2
participant Docker
participant Test Runner
Developer->>GitHub Actions: Push changes
GitHub Actions->>External Workflow v2: Trigger build, pack, test jobs (with updated inputs)
GitHub Actions->>Docker: Build with updated nginx image
GitHub Actions->>Test Runner: Run tests using updated test runner image
External Workflow v2-->>GitHub Actions: Return job results
GitHub Actions-->>Developer: Report CI/CD status
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
.docfx/Dockerfile.docfx (1)
1-1: Update NGINX versions and remove BOM
The base and final stages now usenginx:1.28.0-alpine. Verify there are no breaking changes from 1.27.5 that affect your doc site. Also, the leading BOM () in line 1 can cause Dockerfile parsing issues—please remove it.Also applies to: 11-11
.nuget/Codebelt.Extensions.AspNetCore.Newtonsoft.Json/PackageReleaseNotes.txt (1)
1-1: Remove BOM character
The leading invisible Unicode BOM before “Version 9.0.4” can cause rendering issues in some editors. Remove it to keep the file clean..nuget/Codebelt.Extensions.AspNetCore.Mvc.Formatters.Newtonsoft.Json/PackageReleaseNotes.txt (1)
1-1: Remove BOM character
An invisible BOM may be present before “Version 9.0.4”. Removing it prevents formatting anomalies across editors..nuget/Codebelt.Extensions.Newtonsoft.Json/PackageReleaseNotes.txt (1)
1-1: Remove BOM character
Ensure there’s no leading BOM before “Version 9.0.4” to avoid hidden characters in the file.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
.docfx/Dockerfile.docfx(2 hunks).github/workflows/pipelines.yml(3 hunks).nuget/Codebelt.Extensions.AspNetCore.Mvc.Formatters.Newtonsoft.Json/PackageReleaseNotes.txt(1 hunks).nuget/Codebelt.Extensions.AspNetCore.Newtonsoft.Json/PackageReleaseNotes.txt(1 hunks).nuget/Codebelt.Extensions.Newtonsoft.Json.App/PackageReleaseNotes.txt(1 hunks).nuget/Codebelt.Extensions.Newtonsoft.Json/PackageReleaseNotes.txt(1 hunks)CHANGELOG.md(1 hunks)Directory.Packages.props(1 hunks)testenvironments.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: call-test (windows-2022, Debug) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug) / 🧪 Test
- GitHub Check: call-pack (Release) / 📦 Pack
- GitHub Check: call-pack (Debug) / 📦 Pack
🔇 Additional comments (13)
.github/workflows/pipelines.yml (3)
30-30: Ensure compatibility with v2 of the build workflow
You’ve bumpedjobs-dotnet-buildto@v2. Confirm that the v2 default workflow still accepts the sameconfigurationandstrong-name-key-filenameinputs or adjust as needed to avoid breaking the build.
44-44: Verify impact of removing the pack artifact upload
Theupload-packed-artifactinput was removed from the pack job. Ensure that downstream jobs (e.g.,deploy) still obtain the built package—either via default v2 behavior or by re-adding artifact publishing.
57-62: Validate v2 test workflow signature and the new restore flag
You’ve upgradedjobs-dotnet-testto@v2and addedrestore: true. Confirm that the v2 workflow supports bothruns-onandbuild-switchesinputs alongside the newrestoreparameter, and verify that caching/restore behavior remains correct across your matrix.CHANGELOG.md (1)
10-13: Changelog entry aligns with format
The new## [9.0.4] - 2025-06-15header and its description follow the Keep a Changelog guidelines and mirror prior entries.testenvironments.json (1)
12-12: Confirm updated test runner image
You’ve bumped the Docker image togimlichael/ubuntu-testrunner:net8.0.411-9.0.301. Make sure this tag is published and includes the required .NET 8.0.411–9.0.301 runtimes..nuget/Codebelt.Extensions.Newtonsoft.Json.App/PackageReleaseNotes.txt (1)
1-5: Package release notes updated correctly
The newVersion 9.0.4entry matches the existing format and clearly documents that dependencies were upgraded for .NET 8 and .NET 9..nuget/Codebelt.Extensions.AspNetCore.Newtonsoft.Json/PackageReleaseNotes.txt (1)
1-6: Approve new 9.0.4 release entry
The entry correctly lists .NET 9 and .NET 8 availability and captures the ALM change for dependency upgrades..nuget/Codebelt.Extensions.AspNetCore.Mvc.Formatters.Newtonsoft.Json/PackageReleaseNotes.txt (1)
1-6: Approve new 9.0.4 release entry
The new version header and ALM note correctly reflect the dependency upgrades for .NET 9 and .NET 8..nuget/Codebelt.Extensions.Newtonsoft.Json/PackageReleaseNotes.txt (1)
1-6: Approve new 9.0.4 release entry
The update accurately adds .NET 9, .NET 8, and .NET Standard 2.0 support with a clear ALM note on dependency upgrades.Directory.Packages.props (4)
6-16: Approve central package version bumps
All Codebelt.Extensions.Xunit, Cuemon packages, and Microsoft.NET.Test.Sdk have been correctly updated to their new versions to align with the 9.0.4 service release.
24-24: Approve xunit.runner.visualstudio upgrade
The test runner has been correctly bumped to 3.1.1 to maintain compatibility with the updated xUnit packages.
27-27: Approve .NET 9 conditional dependency update
The Microsoft.AspNetCore.Mvc.NewtonsoftJson package is correctly bumped to 9.0.6 for net9 targets.
30-30: Approve .NET 8 conditional dependency update
The Microsoft.AspNetCore.Mvc.NewtonsoftJson package is correctly bumped to 8.0.17 for net8 targets.
|
1 participant
This pull request includes updates to dependencies, workflows, and package versions across the project to ensure compatibility with the latest frameworks and tools. It also includes minor improvements to documentation and changelog entries. Below is a summary of the most important changes grouped by theme.
Dependency Updates:
.docfx/Dockerfile.docfx: Updated the base and final images fromnginx:1.27.5-alpinetonginx:1.28.0-alpine. [1] [2]Directory.Packages.props: Upgraded multiple package versions, includingCuemon.AspNetCore.Mvcto9.0.6,Codebelt.Extensions.Xunitto10.0.3, andMicrosoft.NET.Test.Sdkto17.14.1.testenvironments.json: Updated the Docker image for the Ubuntu test runner togimlichael/ubuntu-testrunner:net8.0.411-9.0.301.Workflow Enhancements:
.github/workflows/pipelines.yml: Updated workflow actions to use versionv2ofcodebeltnet/jobs-dotnet-build,codebeltnet/jobs-dotnet-pack, andcodebeltnet/jobs-dotnet-test. Added arestoreparameter to the test job and removedupload-packed-artifactfrom the pack job. [1] [2] [3]Documentation Updates:
.nuget/.../PackageReleaseNotes.txt: Updated release notes for multiple packages to version9.0.4, highlighting dependency upgrades and compatibility with.NET 9and.NET 8. [1] [2] [3] [4]CHANGELOG.md: Added an entry for version9.0.4, documenting the focus on package dependencies.Summary by CodeRabbit