add default value to profile env variable #3443
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Assignment of
undefined
profile to env variable withprocess.env.profile
resulted in a string of"undefined"
.This results in mysterious behaviors with code like
const profile = process.env.profile || 'chrome'
. The env variable cannot evaluate tofalse
as it holds the stringundefined
.This PR sets as empty string as default value, so not setting any profile in the command results in an empty string of the profile env variable.
Resolves #3339
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs
)npm run lint
)npm test
)