Fix no error when /config.json doesn't exist #3

Jager567 · 2018-08-17T21:21:55Z

I rewrote the LoadConfig() function to actually return an error when os.Stat("/config.json") failed.
The previous code declared a new err in the scope of the if statement, but then returned the empty one from the named return values.

When there was an error with the os.Stat call, we would return nil. This is because a new variable was created instead of the named return value assigned and returning nil explicitly instead of relying on the named returns.

I think the method looks cleaner when you have less nested code blocks. This way your brain has to do less thinking, because when no errors occur you just have to follow the leftmost indented code to see how it works. Only in unusual situations where errors occur you have to start reading nested code.

Jager567 added 2 commits August 17, 2018 00:33

Fix error not being returned in LoadConfig()

ccca4d1

When there was an error with the os.Stat call, we would return nil. This is because a new variable was created instead of the named return value assigned and returning nil explicitly instead of relying on the named returns.

codeclimate-hermes assigned larkinscott Aug 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix no error when /config.json doesn't exist #3

Fix no error when /config.json doesn't exist #3

Jager567 commented Aug 17, 2018

Fix no error when /config.json doesn't exist #3

Are you sure you want to change the base?

Fix no error when /config.json doesn't exist #3

Conversation

Jager567 commented Aug 17, 2018