Set Java Heap settings #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfleming
force-pushed
the
will/starting-heap
branch
from
b47d155 to
e89dd75
Compare
|
Sigh. JVM behavior can be strange & confusing. Setting only the initial heap failed tests because it was larger than the default max heap. Which is strange because docs say it's either 64MB (really?) or 1GB, but you can also query for it at runtime, which I did in container and the value was, I think, Java's max int value. So I think we were really getting getting the 64mb max heap, which is too small. |
| @@ -25,4 +25,6 @@ RUN npm install | |||
|
|
|||
| USER app | |||
|
|
|||
| ENV JAVA_OPTS="-Xms512m -Xmx1536m" | |||
There was a problem hiding this comment.
Maybe add a comment above this of what each of these do?
|
One comment but otherwise LGTM |
Starting heap 512mb, max heap 1.25GB.
wfleming
force-pushed
the
will/starting-heap
branch
from
e89dd75 to
53bfb3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting heap 512mb, max heap 1.25GB.
👀 @codeclimate/review