Specify similar vs identical code in description #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. LGTM |
|
Fixing test failure |
| @@ -48,7 +48,7 @@ def other_sexps | |||
| @other_locations ||= sorted_hashes.drop(1) | |||
| end | |||
|
|
|||
| def name | |||
| def check_name | |||
There was a problem hiding this comment.
Should identical vs. similar factor into the fingerprint? Maybe out of scope for this?
There was a problem hiding this comment.
Not sure, but I don't think so.
Issues that get better or worse don't change fingerprints. I think a duplication issue moving from Similar to Identical or back is related to, and part of, that issue getting better or worse.
ABaldwinHunter
force-pushed
the
abh-identical-code-description
branch
4 times, most recently
from
b003ef2 to
af85546
Compare
This information is already present on issue check_name, but the description is more visible.
ABaldwinHunter
force-pushed
the
abh-identical-code-description
branch
from
af85546 to
f86cf21
Compare
ABaldwinHunter
pushed a commit
that referenced
this pull request
Jan 15, 2016
Specify similar vs identical code in description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This information is already present on issue check_name, but the description is more visible.
@codeclimate/review