Run one file at a time #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ); | ||
| foreach ($files as &$file) { | ||
| $phpmd->processFiles( | ||
| $file,//implode(",", $files), |
There was a problem hiding this comment.
Any reason you're keeping the commented out bit?
In my testing, this `implode` call was taking a really long time to run, and phpmd itself seemed faster when only given one file at a time.
|
LGTM. I wonder how this was interacting with the fork-daemon stuff in |
|
@wfleming As i watched the output (with lots of extra logging), each worker would hang at the implode call for a bit. |
|
@gordondiggs Oh, I totally believe you. I'm just unclear on how the fork-daemon is working or what it's doing. I thought the fork-daemon basically dispatched individual files to workers, but this makes it look more like it does some kind of batching? Maybe that's what this line controls. |
|
@wfleming I think that is correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my testing, this
implodecall was taking a really long time to run,and phpmd itself seemed faster when only given one file at a time.
@codeclimate/review