FileListResolver: handle non-existent files #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a more complete and targeted spec for this class.
wfleming
force-pushed
the
will/resolve-nonexistent-files
branch
from
44aee1b to
cdf9912
Compare
|
Nice! LGTM |
wfleming
added a commit
that referenced
this pull request
Feb 17, 2016
FileListResolver: handle non-existent files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple crashes came up this morning as a result of non-existent files trying to be read by the file list resolver. This bug surfaced because of the changes to trying to make all paths absolute.
Took the opportunity to test this class more broadly, as well.
@codeclimate/review