Skip to content

feat(firestore): changed valueChanges() arg to options object #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2019
Merged

feat(firestore): changed valueChanges() arg to options object #1

merged 2 commits into from
May 10, 2019

Conversation

jorroll
Copy link

@jorroll jorroll commented Jan 25, 2019

This PR updates your PR by making the optional argument to valueChanges() an options object (to future proof things.

@jorroll jorroll mentioned this pull request Jan 25, 2019
Merged
@jorroll
Copy link
Author

jorroll commented Feb 8, 2019

@codediodeio any chance of getting this merged?

@jorroll
Copy link
Author

jorroll commented May 10, 2019

@codediodeio ping

@codediodeio codediodeio merged commit 4a4a1f5 into codediodeio:collection-idField May 10, 2019
@jorroll jorroll deleted the collection-idFieldUpdate branch May 10, 2019 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorroll @codediodeio