This repository was archived by the owner on Sep 19, 2018. It is now read-only.
Fix for missing location - ouyeah #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ialja
added a commit
that referenced
this pull request
Sep 24, 2014
Fix for missing location - ouyeah
|
👯 |
|
how the h*ll does the browser language affect this? 😖 great find 👍
yes... yes it is 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to reproduce the zero lat, lng issue #308 in Firefox with browser language set to Slovenian and sometimes even in Chrome with language set to Slovenian (as a primary browser language). For some unknown reasons everything worked fine in Chrome when language was set to English.
Anyway, the issue was a missing call to update longitude and latitude ( issue #336 ). After adding this call I haven't been able to reproduce the issue again, so I think it is safe to assume it is fixed... for now. :)
@goranche It is already tomorrow now. 🐱