Skip to content

1795 auth redirect logged out #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

HuanFengYeh
Copy link
Collaborator

Summary

This PR implements a pop-up modal for logged-out users attempting to access auth-required pages(newsfeed page). After successful authentication, users are redirected back to the originally requested page.If the user closes the modal, they are redirected to the homepage.

Checklist

  • On the frontend, I've made my strings translate-able.
  • If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.

Screenshots

Login/Signup Modal for Logged-Out Users
Screenshot 2025-06-11 at 8 13 55 AM

Known issues

  • On authorized(log in) newsfeed page, there’s a brief flash of the modal if refresh the page.

  • When user log out on newsfeed page will redirect to homepage and modal will also be triggered.

Steps to test/reproduce

For each feature or bug fix, create a step by step list for how a reviewer can test it out. E.g.:

  1. Ensure you are logged out.
  2. Go to the newsfeed page (/newsfeed).
  3. Refresh the page and confirm the modal remains open (does not close).
  4. Close the modal (e.g., click the close button) and verify redirection to the homepage (/).
  5. Go back to the newsfeed page (/newsfeed).
  6. Finish login flow.
  7. Confirm that after authentication, the modal closes, and you are redirected to the newsfeed page.
  8. Log out and check that you are redirected to the homepage with the modal on.

Copy link

vercel bot commented Jun 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2025 1:47am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant