Reenable BMG examples in CI testing #358
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t4c1
changed the title
muhammad-tanvir-1211
approved these changes
May 8, 2025
FMarno
reviewed
May 12, 2025
| block_C.reset(static_cast<std::size_t>(M) * N * L); | ||
| block_D.reset(static_cast<std::size_t>(M) * N * L); | ||
| block_ref_D.reset(static_cast<std::size_t>(M) * N * L); | ||
| } catch(...){ |
There was a problem hiding this comment.
It may be simpler to just update the allocation call of DeviceAllocation, rather than all of it's uses
There was a problem hiding this comment.
After some internal discussion and testing I have instead reverted the changes to the examples. It turns out they already print about oom if they encounter that.
This reverts commit ca79d8a.
aacostadiaz
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reenables BMG examples in CI testing, but runs examples sequentially. Examples are also changed to report if they fail to allocate memory.