Skip to content

retrieving extensions from a custom marketplace #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KolyaKorruptis opened this issue Jun 3, 2020 · 8 comments
Closed

retrieving extensions from a custom marketplace #1762

KolyaKorruptis opened this issue Jun 3, 2020 · 8 comments

Comments

@KolyaKorruptis
Copy link

In order to get extensions from a custom marketplace, the FAQ suggest to set two environment variables: $SERVICE_URL and $ITEM_URL. In my experience these are ignored by code-server.

It turns out you can still achieve this is editing the file: code-server/lib/vscode/product.json
Copying the extension related settings from another product.json like this one for example provided me with all the updated extensions.

@ctaoist
Copy link

ctaoist commented Jun 4, 2020

Thanks very much and that is very helpful!!!
Some extensions that code server caches are too old or have wrong platform version, for example, codelldb issue 314

@nhooyr
Copy link
Contributor

nhooyr commented Jun 4, 2020

@KolyaKorruptis Why'd you end up closing this issue? Did the environment variables end up working?

@nhooyr
Copy link
Contributor

nhooyr commented Jun 4, 2020

Just tested and $SERVICE_URL does still work for me at least.

@nhooyr
Copy link
Contributor

nhooyr commented Jun 4, 2020

@KolyaKorruptis Yes you technically can use Microsoft's marketplace but please note it is against their terms of use.

See https://github.com/cdr/code-server/blob/master/doc/FAQ.md#differences-compared-to-vs-code

nhooyr added a commit that referenced this issue Jun 4, 2020
nhooyr added a commit that referenced this issue Jun 4, 2020
@nhooyr
Copy link
Contributor

nhooyr commented Jun 4, 2020

Documented this further in #1767

@KolyaKorruptis
Copy link
Author

@nhooyr I closed it immediately, because it isn't actually a feature request. There isn't anything to do here. It's just some information I wanted to pass on.
I realize that if one would use these exact settings, they would technically be in conflict with the TOS, albeit the chances of these being enforced on end users seem pretty slim.

Regarding the env vars: I may have forgotten to source .bashrc after setting them. Not sure, I'd have to test again. But the changes I described above are easier and more encompassing, as you can also add extension recommendations, etc. So I would always prefer that way.

Nevertheless some more description on $SERVICE_URL and $ITEM_URL would be welcome. At least it should be mentioned that they are supposed to be set as environment variables. Perhaps even with an example. I wasn't sure if the $-sign should be part of the definition or not. The weirdly overgeneralized named PASSWORD does not take a $-sign.

@nhooyr
Copy link
Contributor

nhooyr commented Jun 4, 2020

Nevertheless some more description on $SERVICE_URL and $ITEM_URL would be welcome. At least it should be mentioned that they are supposed to be set as environment variables. Perhaps even with an example. I wasn't sure if the $-sign should be part of the definition or not. The weirdly overgeneralized named PASSWORD does not take a $-sign.

I understand but that's standard notation for environment variables. It comes from shell scripts. It gets verbose otherwise to explicitly mention environment variable everywhere.

@KolyaKorruptis
Copy link
Author

Ah, I see, well that's just my ineptitude on linux then. Nevermind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants