Skip to content

healthcheck path #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ribrdb opened this issue Aug 3, 2020 · 1 comment · Fixed by #1984
Closed

healthcheck path #1940

ribrdb opened this issue Aug 3, 2020 · 1 comment · Fixed by #1984
Milestone
v3.6.0

Comments

@ribrdb
Copy link

ribrdb commented Aug 3, 2020

It looks like any http request will cause the heartbeat file to be updated.
Is it possible to add a health checking path that just returns an "OK" response without updating the heartbeat?
That way a reverse proxy can check to see if the server is up without looking like user activity.
@ribrdb ribrdb added the feature label Aug 3, 2020
@nhooyr
Copy link
Contributor

nhooyr commented Aug 17, 2020

Great point! We should just use the standard path /healthz @code-asher

JacobGo added a commit to JacobGo/code-server that referenced this issue Aug 19, 2020
@JacobGo
Added /healthz JSON response for heartbeat data. coder#1940
42485fb
@JacobGo JacobGo mentioned this issue Aug 19, 2020
Merged
@nhooyr nhooyr added this to the v3.5.1 milestone Aug 31, 2020
code-asher pushed a commit that referenced this issue Aug 31, 2020
@JacobGo
Added /healthz JSON response for heartbeat data. #1940 (#1984)
75c8fde
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging a pull request may close this issue.

Added /healthz JSON response for heartbeat data. #1940 JacobGo/code-server
3 participants
@ribrdb @nhooyr @code-asher