Skip to content

'X-Frame-Options' Issus in extension detail page #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iWangJiaxiang opened this issue Sep 9, 2019 · 4 comments
Closed

'X-Frame-Options' Issus in extension detail page #962

iWangJiaxiang opened this issue Sep 9, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@iWangJiaxiang
Copy link

  • code-server version: 2.preview.11-vsc1.37.0
  • OS Version: Ubuntu 18.04

Description

The extension detail page could not be loaded due to X-Frame-Options Issus

image

Steps to Reproduce

  1. Run code-server
  2. Open Extension page of code server
  3. Click any extension to open detail page on the right side
  4. The extension detail page could not be loaded
@iWangJiaxiang iWangJiaxiang added the bug Something isn't working label Sep 9, 2019
@iWangJiaxiang
Copy link
Author

iWangJiaxiang commented Sep 9, 2019 •
edited
Loading

I found the reason!

According to the self-hosted doc, The proxy server has been set to add

add_header X-Frame-Options DENY;

So I just simply modify it to

add_header X-Frame-Options SAMEORIGIN;

And every works perfectly now.

Please update your document~

@sr229 sr229 added the v2 label Sep 12, 2019
@sr229
Copy link
Contributor

sr229 commented Sep 12, 2019

CC @code-asher

sr229 added a commit that referenced this issue Sep 12, 2019
@sr229
[doc/self-hosted] make XFO same origin in docs
14a74b7 
As reported in GH-962, this breaks VSCode's extension details view. Might need further triage if its also a v2 internal issue.
@sr229 sr229 mentioned this issue Sep 12, 2019
Merged
@code-asher
Copy link
Member

code-asher commented Sep 12, 2019 via email

code-asher pushed a commit that referenced this issue Sep 12, 2019
@sr229 @code-asher
[doc/self-hosted] make XFO same origin in docs (#970)
64cc289 
As reported in GH-962, this breaks VSCode's extension details view. Might need further triage if its also a v2 internal issue.
@sr229
Copy link
Contributor

sr229 commented Sep 12, 2019

I'll mark this as resolved for now since we already updated the docs which shouldn't break v2 now.

@sr229 sr229 closed this as completed Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sr229 @iWangJiaxiang @code-asher