feat: persist route query to local

[fxxjdedd]

Provide a way for the shell script running in the docker container to get the url query.

[code-asher]

Thanks for the contribution! Could you expound on the use case?

[fxxjdedd]

Thank you for your reply.
The use case is: the URL of our web ide will carry some dynamic parameters, such as user, project, cluster, etc. These parameters need to be obtained in the debugger and terminal.

I did not find a solution to the problem, so I think this may be a new feature.

[code-asher]

Interesting, thanks for the additional details. We already have a file that contains the last visited path in ~/.local/share/code-server/coder.json (just a bit further down in getRoot). Would it work for your use case to add the query variables as JSON to that file instead?

[fxxjdedd]

Of course, it will help a lot！

…

------------------ Original ------------------ From: Asher <[email protected]&gt; Date: Wed,Jul 29,2020 11:41 PM To: cdr/code-server <[email protected]&gt; Cc: fxxjdedd <[email protected]&gt;, Author <[email protected]&gt; Subject: Re: [cdr/code-server] feat: persist route query to local (#1920) Interesting, thanks for the additional details. We already have a file that contains the last visited path in ~/.local/share/code-server/coder.json (just a bit further down in getRoot). Would it work for your use case to add the query variables to the lastVisited object in that file instead? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[code-asher]

Awesome, let's go that route then.

[fxxjdedd]

@code-asher

I made some changes and it works fine locally.

[fxxjdedd]

emmm, I have some different opinions: Although await is clearer, but it&nbsp;will blocks all the code below, but promise.then will not.&nbsp; On the other hand, if they are written together, the query will be updated using extends, so that when the query becomes empty, the data in the settings will not be updated correctly

…

------------------ Original ------------------ From: Asher <[email protected]&gt; Date: Fri,Jul 31,2020 0:16 AM To: cdr/code-server <[email protected]&gt; Cc: fxxjdedd <[email protected]&gt;, Author <[email protected]&gt; Subject: Re: [cdr/code-server] feat: persist route query to local (#1920) @code-asher requested changes on this pull request. In src/node/app/vscode.ts: &gt; if (startPath) { - settings.write({ - lastVisited: startPath, - }) + promise = settings.write({ lastVisited: startPath }) Ah oops, this is a bug on my part because I forgot to await the promise. I think it might be a bit cleaner to use await. We can also update both values at the same time since the default value of startPath is the old value that was in the settings. In src/node/settings.ts: &gt; @@ -55,6 +58,7 @@ export interface CoderSettings extends UpdateSettings { url: string workspace: boolean } + query: Route["query"] I didn't know you could do this. Very cool! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[code-asher]

That's fair, let's leave out the await.

We can pass true when updating both to use the shallow update. That's actually preferable anyway because the lastVisited object should be replaced entirely.

[code-asher]

In fact I'm thinking about removing extends entirely because I'm not sure we even need a recursive merge.

[fxxjdedd]

cool, let‘s have a try!

…

------------------ Original ------------------ From: Asher <[email protected]&gt; Date: Fri,Jul 31,2020 0:42 AM To: cdr/code-server <[email protected]&gt; Cc: fxxjdedd <[email protected]&gt;, Author <[email protected]&gt; Subject: Re: [cdr/code-server] feat: persist route query to local (#1920) In fact I'm thinking about removing extends entirely because I'm not sure we even need a recursive merge. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[code-asher]

Awesome. Thanks for the contribution!