Skip to content

Ensure workspace configPath is a valid URI object #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2019

Conversation

foresthoffman
Copy link
Contributor

Describe in detail the problem you had and how this PR fixes it

Adding a folder to a workspace results in a failure to reload the workspace. This was due to the workspace URI being invalid. The scheme (https://tools.ietf.org/html/rfc3986#section-3.1) for the URI was actually the path to the workspace configuration file, so the URI would always fail to parse upon workspace initialization.

This PR will ensure that the configuration path is actually defined as a valid file:// URI, instead of simply casting it.

Is there an open issue you can link to?

Fixes #309

@broady
Copy link

broady commented Mar 25, 2019

Can we get a version of this released?

(or is there some easy way for me to easily run a copy of code-server at a particular commit, in a similar fashion to the single binary distro? sorry, a bit of a Node.js noob here)

edit: got it, found it was easiest via docker build and copying the file out of the docker image.

@nol166
Copy link
Contributor

nol166 commented Mar 25, 2019

@broady You can clone the repo and then:

  1. Cd into code-server
  2. Run yarn
  3. Run yarn task build:binary:linux or darwin depending on what OS you are using

It should output the CLI to packages/server/cli-(os)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add folder to workspace results in grey screen
4 participants