Skip to content

Update Code to 1.80.1 #6340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 19, 2023
Merged

Update Code to 1.80.1 #6340

merged 3 commits into from
Jul 19, 2023

Conversation

benz0li
Copy link
Contributor

@benz0li benz0li commented Jul 18, 2023

Closes #6316

@benz0li benz0li requested a review from a team as a code owner July 18, 2023 04:51
@benz0li
Copy link
Contributor Author

benz0li commented Jul 18, 2023

code-server-4.15.0-rc.1-linux-amd64.tar.gz is deployed at https://coder.jupyter.b-data.ch; Image R (base:test-devtools-docker).

Functionality [modified by patches] tested and found to work:

  • base-path
  • cli-window-open
  • local-storage
  • marketplace
  • proxy-url
  • service-worker
  • webview

Jupyter Notebooks also work fine:

code-asher
code-asher reviewed Jul 18, 2023
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! Looks really great, I think display languages are the only thing we need to fix (see review comment).

CI seems to keep timing out while building, investigating...

@code-asher
Copy link
Member

I think maybe we just have to bump up the timeout on the build step. Not sure why it seems to be taking longer than normal but oh well.

@benz0li
Copy link
Contributor Author

benz0li commented Jul 19, 2023

I think maybe we just have to bump up the timeout on the build step. Not sure why it seems to be taking longer than normal but oh well.

yarn build:vscode took 35 mins on my server (Intel® Xeon® Silver 4210R).

@benz0li benz0li mentioned this pull request Jul 19, 2023
Closed
code-asher
code-asher approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah!

@code-asher code-asher merged commit 788da5d into coder:main Jul 19, 2023
@benz0li
Copy link
Contributor Author

benz0li commented Jul 21, 2023

code-server-4.15.0-rc.1-linux-amd64.tar.gz from Release v4.15.0-rc.1 is deployed at https://coder.jupyter.b-data.ch; Image R (base:test-devtools-docker).

Test results are identical to #6340 (comment). @alexthillen Is flag --trusted-origin working as expected?

@alexthillen
Copy link
Contributor

alexthillen commented Jul 21, 2023 •
edited
Loading

Yes :)

@code-asher
Copy link
Member

Thanks, all! I will promote the release today.

@benz0li benz0li mentioned this pull request Nov 21, 2023
Closed
yiliang114 pushed a commit to yiliang114/code-server that referenced this pull request Jan 23, 2025
@benz0li @yiliang114
Update Code to 1.80.1 (coder#6340)
45e719a 
* Update Code to 1.80.1 (coder#6340)
* Give build workflow more time to run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat]: Update Code to 1.80
3 participants
@benz0li @code-asher @alexthillen