Skip to content

Remove humanPath #6404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Remove humanPath #6404

merged 1 commit into from
Aug 29, 2023

Conversation

code-asher
Copy link
Member

The tilde is ambiguous and it can be helpful to know exactly what paths code-server is trying to use, especially if it is running as a different user than you expected.

May help with #6388, #6389, and #6380

@code-asher code-asher requested a review from a team as a code owner August 28, 2023 20:23
The tilde is ambiguous and it can be helpful to know exactly what paths
code-server is trying to use, especially if it is running as a different
user than you expected.
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #6404 (2c2af35) into main (e37b352) will decrease coverage by 0.10%.
Report is 11 commits behind head on main.
The diff coverage is 70.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6404      +/-   ##
==========================================
- Coverage   73.71%   73.61%   -0.10%     
==========================================
  Files          31       31              
  Lines        1887     1880       -7     
  Branches      407      406       -1     
==========================================
- Hits         1391     1384       -7     
  Misses        419      419              
  Partials       77       77              
Files Changed Coverage Δ
src/node/util.ts 88.46% <ø> (-0.25%) ⬇️
src/node/cli.ts 90.84% <50.00%> (-0.04%) ⬇️
src/node/main.ts 51.54% <66.66%> (-0.50%) ⬇️
src/node/routes/login.ts 87.71% <100.00%> (-0.22%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb8099f...2c2af35. Read the comment docs.

@code-asher code-asher merged commit eb498b0 into coder:main Aug 29, 2023
@code-asher code-asher deleted the remove-human-path branch August 29, 2023 22:25
yiliang114 pushed a commit to yiliang114/code-server that referenced this pull request Jan 23, 2025
The tilde is ambiguous and it can be helpful to know exactly what paths
code-server is trying to use, especially if it is running as a different
user than you expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant