-
Notifications
You must be signed in to change notification settings - Fork 0
Coder Inbox Web UI #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
This was referenced Feb 4, 2025
@BrunoQuaresma As we talked during Weekly on Monday, it seems to be not a blocker anymore. Can you please flush out the scope of changes? |
@mtojek same as coder/coder#16422 (comment) |
BrunoQuaresma
added a commit
to coder/coder
that referenced
this issue
Mar 12, 2025
Related to coder/internal#336 This PR adds the base components for the Notifications UI below (you can click on the image to open the related Figma design) based on the response structure defined on this [notion doc](https://www.notion.so/coderhq/Coder-Inbox-Endpoints-1a1d579be592809eb921f13baf18f783). [](https://www.figma.com/design/5kRpzK8Qr1k38nNz7H0HSh/Inbox-notifications?node-id=2-1098&m=dev) **What is not included** - Support for infinite scrolling (pending on BE definition) **How to test the components?** - The only way to test the components is to use Chromatic or downloading the branch and running Storybook locally.
Unblocking this for now since I can work on it creating a new branch from the one on this notifications BE PR. |
BrunoQuaresma
added a commit
to coder/coder
that referenced
this issue
Mar 18, 2025
**Preview:** <img width="479" alt="Screenshot 2025-03-18 at 10 38 25" src="https://github.com/user-attachments/assets/2e4cb48e-3606-478c-a68d-13465789330b" /> [Figma file](https://www.figma.com/design/5kRpzK8Qr1k38nNz7H0HSh/Inbox-notifications?node-id=1-2726&t=PUsQwLrwyzXUxhf1-0) **This PR adds:** - Notification widget in the navbar - Show notifications - Option to mark each notification as read - Update notifications in realtime **What is next?** - Option to mark all the notifications as read at once - Option to load previous notifications - Right now, it only shows the latest 25 notifications - Having custom icons for each type of notification **And about tests?** The notification widget components are well covered by the current stories, but we definitely want to have e2e tests for it. However, in my recent projects, I found more useful to ship the UI features first, get feedback, change whatever needs to be changed, and then, add the e2e tests to avoid major rework. Related to coder/internal#336
EdwardAngert
pushed a commit
to coder/coder
that referenced
this issue
Mar 18, 2025
Related to coder/internal#336 This PR adds the base components for the Notifications UI below (you can click on the image to open the related Figma design) based on the response structure defined on this [notion doc](https://www.notion.so/coderhq/Coder-Inbox-Endpoints-1a1d579be592809eb921f13baf18f783). [](https://www.figma.com/design/5kRpzK8Qr1k38nNz7H0HSh/Inbox-notifications?node-id=2-1098&m=dev) **What is not included** - Support for infinite scrolling (pending on BE definition) **How to test the components?** - The only way to test the components is to use Chromatic or downloading the branch and running Storybook locally.
EdwardAngert
pushed a commit
to coder/coder
that referenced
this issue
Mar 18, 2025
**Preview:** <img width="479" alt="Screenshot 2025-03-18 at 10 38 25" src="https://github.com/user-attachments/assets/2e4cb48e-3606-478c-a68d-13465789330b" /> [Figma file](https://www.figma.com/design/5kRpzK8Qr1k38nNz7H0HSh/Inbox-notifications?node-id=1-2726&t=PUsQwLrwyzXUxhf1-0) **This PR adds:** - Notification widget in the navbar - Show notifications - Option to mark each notification as read - Update notifications in realtime **What is next?** - Option to mark all the notifications as read at once - Option to load previous notifications - Right now, it only shows the latest 25 notifications - Having custom icons for each type of notification **And about tests?** The notification widget components are well covered by the current stories, but we definitely want to have e2e tests for it. However, in my recent projects, I found more useful to ship the UI features first, get feedback, change whatever needs to be changed, and then, add the e2e tests to avoid major rework. Related to coder/internal#336
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Part of the main PR visible here.
This PR scope is to create the Web UI component for the Coder Inbox.
It depends on #335 - API Endpoints endpoints.
The scope of this PR is everything associated to the Web UI from the icon on topbar to list of notifications and pagination.
The text was updated successfully, but these errors were encountered: