fix: add missing README information and clean up types #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matifali @Parkreiner can we cut a release as soon as this is merged? |
Atif and I just cut a release this afternoon. Were there any major changes after that? I would think this PR is just infrastructure stuff that won't affect end-users |
bcpeinhardt
approved these changes
Jul 19, 2024
matifali
reviewed
Jul 20, 2024
| @@ -3,14 +3,14 @@ | |||
| Modules | |||
| </h1> | |||
|
|
|||
| [Registry](https://registry.coder.com) | [Coder Docs](https://coder.com/docs) | [Why Coder](https://coder.com/why) | [Coder Enterprise](https://coder.com/docs/v2/latest/enterprise) | |||
| [Module Registry](https://registry.coder.com) | [Coder Docs](https://coder.com/docs) | [Why Coder](https://coder.com/why) | [Coder Enterprise](https://coder.com/docs/v2/latest/enterprise) | |||
There was a problem hiding this comment.
Registry also hosts templates source code at https://registry.coder.com/templates
matifali
reviewed
Jul 20, 2024
|
|
||
| Following that, our automated processes will handle publishing new data for [`registry.coder.com`](https://github.com/coder/registry.coder.com/): | ||
|
|
||
| 1. Publishing new versions to Coder's [Terraform Registry](https://registry.terraform.io/providers/coder/coder/latest) |
There was a problem hiding this comment.
We do not publish anything to terraform registry.
matifali
approved these changes
Jul 20, 2024
There was a problem hiding this comment.
Looking great for now. It may change once we implement independent versioning for each module.
matifali
requested changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little bit of cleanup to make the repo easier to maintain.
Changes made
anytypesNotes
tsconfig.jsonfile cleaned up, too (the compiler settings are technically invalid, even though nothing seems to break), but that took me down a rabbi thole of ESM-CSJ interop. Aiming to address that in a separate PR