feat(filebrowser): support subdomain = false #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seppdo
changed the title
matifali
reviewed
Aug 30, 2024
filebrowser/README.md
Outdated
Comment on lines
48
to
59
| ### Serve from the same domain (no subdomain) | ||
|
|
||
| Make sure to set both workspace_name and owner_name. | ||
|
|
||
| ```tf | ||
| module "filebrowser" { | ||
| source = "registry.coder.com/modules/filebrowser/coder" | ||
| agent_id = coder_agent.main.id | ||
| workspace_name = data.coder_workspace.me.name | ||
| owner_name = data.coder_workspace_owner.me.name | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Also update the example accordingly.
matifali
reviewed
Aug 30, 2024
matifali
requested changes
Aug 30, 2024
|
You can also check my review for #288 and do a similar approach. In this case you can discard the requested changes. |
Co-authored-by: Muhammad Atif Ali <[email protected]>
Co-authored-by: Muhammad Atif Ali <[email protected]>
Co-authored-by: Muhammad Atif Ali <[email protected]>
Co-authored-by: Muhammad Atif Ali <[email protected]>
Co-authored-by: Muhammad Atif Ali <[email protected]>
Co-authored-by: Muhammad Atif Ali <[email protected]>
Co-authored-by: Muhammad Atif Ali <[email protected]>
matifali
reviewed
Sep 1, 2024
Add missing subdomain variable
- Fix subdomain variable expected as number by count in data fields - Add test case for subdomain=false
matifali
reviewed
Sep 17, 2024
Co-authored-by: Muhammad Atif Ali <[email protected]>
- Add agent_name to test cases since it is a required variable (even on those cases where it is not actually needed) - Prettify README.md
|
Since agent_name is a required parameter, it must be set even in cases where it is not actually needed (e.g. every case with subdomain=true) I think users are fine with this, especially since they can just copy the example in the readme. |
|
I don't know how to fix the error in the pretty check |
|
@Seppdo can you run |
matifali
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #285.
Add variables
workspace_name,owner_nameandresource_nameto be able to infer the directory the module is served at. Set this directory in the filebrowser app via thefilebrowser config set --baseurlfunction.Added an example to readme.