fix: use the proper logs for filebrowser and add generic testBaseLine function
#418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Mar 31, 2025
|
Oh, oops. My diff just showed the formatting, but looks good. |
matifali
approved these changes
Mar 31, 2025
|
@phorcys420 are you still on it? If not I can take a look at it. |
|
@matifali I thought i'd merged this! |
Yes, please. I may not have time this week. So I can take a look next week if you haven't already. |
matifali
force-pushed
the
fix-filebrowser-tests
branch
from
6b53f25 to
4248ae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #400 that fixes the tests.
bashandcurldepsset -euo pipefail(previously, the script was completely failing due to unknown commands but exit code was 0, hence why tests passed even though our testing setup was broken)toEqualcalls and replaced them withtoContainsto avoid the tests breaking if the log lines aren't exactly what is set.The new script version doesn't log command (e.g
"Running 'filebrowser --noauth --root /home/coder/project --port 13339 --baseurl ' ") so I also removed that, but I could reimplement this because we only test for the exit code and generic logs now, but we don't actually check if the proper command is ran.In the long-term, we should overhaul our testing to do proper e2e testing (e.g actually runnign healthchecks on the modules' backend), but in the mean-time we should also make all of our scripts stricter to be able to actually catch these issues.