fix: keep binary in same place, update if needed #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
force-pushed
the
jsjoeio/fix-binary-windows
branch
from
4caf765 to
d06c873
Compare
jsjoeio
commented
Jan 17, 2023
|
What's the easiest way to test these changes locally @kylecarbs ? |
deansheather
approved these changes
Jan 17, 2023
deansheather
previously requested changes
Jan 17, 2023
|
@deansheather re: testing Let me make these changes, build to a |
|
I tested locally on macOS and something is off
Seems like it's trying to use the binary before it's done renaming it? |
This removes the version from the binary path to ensure that the path always remains the same on OS's. This way, tools like Windows Firewall and macOS Firewill will only prompt for a security check on the first install but not subsequent installs.
This makes significant changes to the `fetchBinary` logic. First, it refactors a couple pieces of logic into methods on the `Storage` class to make the code more readable. Then it modifies the flow to first check if the binary is outdated. If it is, then it downloads the latest version.
jsjoeio
force-pushed
the
jsjoeio/fix-binary-windows
branch
from
36da848 to
369a823
Compare
|
I'm going to try rebasing on EDIT: same issue |
|
I figured it out - I was trying to |
This will build a `.vsix` file locally marked as a pre-release which is handy for testing.
|
Tested locally and seems to work 👍🏼
|
This makes a couple new changes: - if 200, move old binPath to binPath.old- - try removing .old binary - on start, cleanUpOldBinaries
- catch all potential errors from `fs` - only rename binPath to old right before replacing with tempFile
This generates the Etag correctly using a readableStream and the appends it to the headers. This also adds some logging around etag, binPath and status code.
|
@deansheather ready for a new review! |
deansheather
approved these changes
Jan 20, 2023
Co-authored-by: Dean Sheather <[email protected]>
Co-authored-by: Dean Sheather <[email protected]>
Kira-Pilot
reviewed
Jan 20, 2023
Kira-Pilot
reviewed
Jan 20, 2023
Kira-Pilot
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@deansheather filed a bug related to the Windows Firewall prompt coming up with every new binary (i.e. every time we download
coderto an updated version).After some initial testing, it appears keeping the binary in the same place will make the prompt only appear on the first time.
Previous implementation kept the version in the path.
We decided to refactor things to add support for ETag on the server and then use those changes on the client (aka in the extension).
This means now the client will tell the server "Here's the version I have. What should I do?" and send the appropriate headers.
Checklist
If-None-Matchheader in your requestTesting Plan
TBD
Fixes #23