Skip to content

Recreate REST client after starting a workspace (part 2) #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

aaronlehmann
Copy link
Contributor

This is a followup to #431. It addresses the need to also recreate the REST client used inside maybeWaitForRunning, since it makes API calls before returning to setup.

This is a followup to coder#431. It addresses the need to also recreate the
REST client used inside `maybeWaitForRunning`, since it makes API calls
before returning to `setup`.
@matifali matifali requested a review from bcpeinhardt February 19, 2025 19:01
Copy link
Collaborator

@bcpeinhardt bcpeinhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcpeinhardt bcpeinhardt merged commit 8134f1f into coder:main Feb 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants