Skip to content

Add NetConn adapter and protect against Reader after CloseRead #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2019

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Jul 1, 2019

Closes #100
Closes #101

@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #102 into master will decrease coverage by 0.91%.
The diff coverage is 56.6%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   75.86%   74.95%   -0.92%     
==========================================
  Files          13       14       +1     
  Lines         986     1038      +52     
==========================================
+ Hits          748      778      +30     
- Misses        184      202      +18     
- Partials       54       58       +4
Impacted Files Coverage Δ
websocket.go 70.27% <0%> (-0.46%) ⬇️
netconn.go 61.22% <61.22%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c4fdf2...9d31b8d. Read the comment docs.

@nhooyr nhooyr merged commit ce67a44 into master Jul 1, 2019
@nhooyr nhooyr deleted the netconn branch July 1, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Reader after CloseRead NetConn adapter
1 participant