refactor(charts): migrate components:chart, chartline to <script setup> #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quangtuanitmo18
requested review from
Copilot and
neSpecc
and removed request for
Copilot and
neSpecc
There was a problem hiding this comment.
Pull request overview
This PR refactors the Chart and ChartLine Vue components from Options API to Composition API using <script setup> syntax, improving code organization and maintainability.
- Converted Chart.vue and ChartLine.vue to use
<script setup>with Composition API - Extracted
ChartLineColorsinterface to shared types file (src/types/chart.ts) - Created new constants file (src/constants/charts.ts) for
chartColorsarray
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/types/chart.ts | Added ChartLineColors interface definition with comprehensive documentation for color gradient properties |
| src/constants/charts.ts | New file containing chartColors constant array with color configurations for chart lines |
| src/components/events/ChartLine.vue | Migrated from Options API to Composition API with script setup, converting props, data, and computed properties |
| src/components/events/Chart.vue | Migrated from Options API to Composition API with script setup, converting props, lifecycle hooks, methods, and computed properties to their Composition API equivalents |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
neSpecc
reviewed
Dec 12, 2025
quangtuanitmo18
force-pushed
the
refactor/vue3-script-setup-migration
branch
from
beb0d81 to
e048818
Compare
quangtuanitmo18
force-pushed
the
refactor/vue3-script-setup-migration
branch
from
e048818 to
eecb45d
Compare
neSpecc
approved these changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(components): migrate Chart components to Vue 3 Composition API - script setup
Goal: decouple chart components from Hawk so they can be moved into CodeX UI and reused across packages (e.g., NoteX and Hawk Admin).
Changes: