Add hover effect to cards. Limit container width. Refs #48 #50
Conversation
|
Note: Hacktoberfest UI is telling me that
|
Thank you for letting us know that! I've added the labels :D |
{{ message }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aniket-Mishra
approved these changes
Oct 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
langattribute to<html>enables screenreaders and crawlers to interpret the website in English (instead of relying on heuristics).By reducing the width of
.card-containera bit, you can get more harmony into the layout, since the maximum width is the same as the about text above. Plus, white-space makes the UI look cleaner.grid-auto-rows: 1frensures, that all cards remain the same height.I've added a small hover effect on the card. Let me know what you think.