-
-
Notifications
You must be signed in to change notification settings - Fork 70
Self-serve account deletion #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ready for review, but let's hold off this one until #1647 is merged. |
We don't allow admins or mods to self-delete (good), but the check is at the end. Instead of sending the user through the sudo path (password, then type user name, then get the error), can we check when the person clicks the button? Other than that, looks great! I tested all the special statuses (local/global mod/admin), and confirmed that staff alone doesn't block deletion. The deletions show up in the audit log as expected, and that email address/password no longer works to sign in. A self-deleted user can sign up again with the same email address and gets a new account. |
Good catch - I meant to just not show the button for special users, perhaps with a caption instead, but forgot to add that. |
Grayed out with an explanation would be consistent with other buttons that are selectively not available. But any way you want to handle it (at the beginning) is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Defer merge until after 1647 merges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM code-wise (have done some manual testing too, but not beyond getting to the sudo screen).
Left a bunch of minor suggestions (mostly upkeep-related) as a separate PR with this one as a target
Suggestions for PR #1668
Adds self-serve account deletion.
Closes #925.