-
-
Notifications
You must be signed in to change notification settings - Fork 70
Search fixes & improvements #1761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…o matches_non_negative_int? to match its intent
… SearchQualifierHelper
Not particularly concerned with covering 100% of the change as we didn't have a single test case before it in the first place - I've added as many as I could for now, we can easily expand on them later. More concerned about manually confirming search works as expected after the change (seems so, but another pair of eyes on it would be nice) |
Tested: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the behavior and reviewed the test cases. I didn't review the implementation code.
… not parsing negative ids (f.e., system)
closes #1128
This PR ensures
votes:
operator can use negative values:Does a general cleanup of qualifier parsing as well in preparation for #1760