Skip to content

Conversation

Oaphi
Copy link
Member

@Oaphi Oaphi commented Aug 7, 2025

closes #1128

This PR ensures votes: operator can use negative values:

Screenshot from 2025-08-07 03-30-04

Does a general cleanup of qualifier parsing as well in preparation for #1760

Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 88.04348% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.78%. Comparing base (4153f8d) to head (9f32949).
⚠️ Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
app/helpers/search_helper.rb 37.50% 10 Missing ⚠️
app/helpers/search_qualifier_helper.rb 98.68% 1 Missing ⚠️
Additional details and impacted files
Components Coverage Δ
controllers 69.86% <ø> (ø)
helpers 81.82% <88.04%> (+2.62%) ⬆️
jobs 60.00% <ø> (ø)
models 86.12% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Oaphi Oaphi marked this pull request as ready for review August 7, 2025 02:23
@Oaphi Oaphi requested review from ArtOfCode-, cellio and a team August 7, 2025 02:24
@Oaphi
Copy link
Member Author

Oaphi commented Aug 7, 2025

Not particularly concerned with covering 100% of the change as we didn't have a single test case before it in the first place - I've added as many as I could for now, we can easily expand on them later. More concerned about manually confirming search works as expected after the change (seems so, but another pair of eyes on it would be nice)

@Oaphi Oaphi added this to the v0.12.3 milestone Aug 7, 2025
@cellio
Copy link
Member

cellio commented Aug 7, 2025

Tested: votes:-1 returns net votes exactly -1, likewise -2 and 0. votes:<=-1 correctly pulls in -2. Behavior looks good to me.

Copy link
Member

@cellio cellio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the behavior and reviewed the test cases. I didn't review the implementation code.

@Oaphi Oaphi merged commit bdc4d55 into develop Aug 7, 2025
13 checks passed
@Oaphi Oaphi deleted the 0valt/1128/search-fixes branch August 7, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't search for net negative votes, and trying it returns wrong results
3 participants