Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures fixes caching behavior for user notifications (currently, in production we allow those to get cached for a day with no regard to new notifications). It also makes it possible to test response caching in development as it turns out Rack::MiniProfiler overwrites cache control headers even if
perform_caching
is set totrue
. Finally, it also fixes aDoubleRenderError
when requestingthread_content
twice in a row (that's not in production yet, I made a mistake when addingfresh_when
withrespond_to
).