Skip to content

Conversation

Oaphi
Copy link
Member

@Oaphi Oaphi commented Sep 13, 2025

This PR ensures fixes caching behavior for user notifications (currently, in production we allow those to get cached for a day with no regard to new notifications). It also makes it possible to test response caching in development as it turns out Rack::MiniProfiler overwrites cache control headers even if perform_caching is set to true. Finally, it also fixes a DoubleRenderError when requesting thread_content twice in a row (that's not in production yet, I made a mistake when adding fresh_when with respond_to).

Copy link

codecov bot commented Sep 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.82%. Comparing base (e2a295b) to head (369d071).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files
Components Coverage Δ
controllers 71.56% <100.00%> (+0.04%) ⬆️
helpers 82.01% <ø> (ø)
jobs 60.00% <ø> (ø)
models 89.02% <ø> (ø)
tasks 61.11% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Oaphi Oaphi requested a review from ArtOfCode- September 13, 2025 20:42
Copy link
Member

@cellio cellio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and notifications showed up promptly in my dev environment, for what that's worth. I see that Art has already reviewed the code, so LGTM.

@Oaphi Oaphi merged commit 5429881 into develop Sep 14, 2025
19 of 20 checks passed
@Oaphi Oaphi deleted the 0valt/caching branch September 14, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants