Skip to content

Improve the error message when using InstanceId.load with a tuple of wrong length #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MortGron
Copy link
Contributor

Description

Curren error message talks about missing external ID key

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@MortGron MortGron changed the title Improved the error message when using InstanceId.load with a tuple of wrong length Improve the error message when using InstanceId.load with a tuple of wrong length Jun 25, 2025
@MortGron MortGron marked this pull request as ready for review June 25, 2025 14:18
@MortGron MortGron requested review from a team as code owners June 25, 2025 14:18
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.65%. Comparing base (a9d591a) to head (74dc4b0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2179   +/-   ##
=======================================
  Coverage   90.65%   90.65%           
=======================================
  Files         159      159           
  Lines       24135    24138    +3     
=======================================
+ Hits        21880    21883    +3     
  Misses       2255     2255           
Files with missing lines Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/utils/_identifier.py 88.65% <100.00%> (+0.40%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MortGron MortGron requested a review from erlendvollset June 28, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants