Add @throws tags to the public API #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
👋, thanks for this package! This is a very minor change that adds
@throws
tags to the docblocks of thejson5_decode
function andJson5Decoder::decode
method—as some IDE's (namely, PhpStorm) don't seem to be able to infer that both of these calls can throw, which leads to inspections about unnecessarily catchingSyntaxError
's.How has this been tested?
No new tests needed, but
composer check-style
reports no problems.Types of changes
Checklist: