Feature/merge upstream #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ify-historic-use Changing label as requested.
…k-box Tweak text in box for land use.
…ower zoom levels.
…-powerful-map-by-ovedrawing Exagerrate building size for EPC layer to make data more visible on lower zoom levels.
…ature/merge-upstream
… low zoom levels.
There was a problem hiding this comment.
Pull Request Overview
This PR improves the Land Use category by updating user-facing text for clarity and adds visual enhancement to map polygon styling.
- Updated category intro text to explicitly mention ownership alongside land use
- Refined user-facing labels for land use data entry sections to better reflect their purpose
- Enhanced map visual rendering by adding matching stroke colors to all polygon fills
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/frontend/config/categories-config.ts | Updated category introduction to mention ownership type alongside use and temporal changes |
| app/src/frontend/building/data-containers/land-use.tsx | Renamed sections from "Specific Land Use/s" to "Current Land Use/s" and "Original Use" to "Original (Historical) Use"; revised instructional text to be more inclusive |
| app/map_styles/polygon.xml | Added LineSymbolizer elements with matching stroke colors to all PolygonSymbolizer rules across all map styles for visual consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+36
to
+38
| Can you help us identify residential, non-residential and mixed use buildings (and verify these too)? | ||
|
|
||
| (In the UK over 90% of properties are residential.) |
There was a problem hiding this comment.
[nitpick] The spacing around the parenthetical note creates an awkward line break. The text should flow more naturally without the blank line between the question and the contextual information.
Suggested change
| Can you help us identify residential, non-residential and mixed use buildings (and verify these too)? | |
| (In the UK over 90% of properties are residential.) | |
| Can you help us identify residential, non-residential and mixed use buildings (and verify these too)? (In the UK over 90% of properties are residential.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.