Skip to content

Conversation

@greatgitsby
Copy link
Contributor

@greatgitsby greatgitsby commented Nov 19, 2025

move bespoke panel switching and bespoke modal handling into a single stack interface

likely going to break out changes from this, there are a few fundamental changes in this PR:

  • set_modal_overlay no longer needed, use stack
  • couple bugs found in keyboard renderer
  • "modal" operated differently than normal "widget" as it had a return code and handled it uniquely. want to make this a general feature of Widget.
  • i hate callback invoking pop, it should be simpler than this (dismiss should auto-handle pop if no action was taken)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant