loggerd/deleter: handle non-directory entries in log root#37736
Open
knQzx wants to merge 1 commit intocommaai:masterfrom
Open
loggerd/deleter: handle non-directory entries in log root#37736knQzx wants to merge 1 commit intocommaai:masterfrom
knQzx wants to merge 1 commit intocommaai:masterfrom
Conversation
os.listdir and shutil.rmtree both fail on plain files. if a user drops a file in the log root it just sits there forever eating disk space. now checks isdir first and uses os.remove for files fixes commaai#30102
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.listdir and shutil.rmtree both fail on plain files, so if something other than a segment directory ends up in the log root it just sits there forever eating disk space. now checks isdir first and uses os.remove for stray files
fixes #30102