[WIP][Tests] Fix locally failing tests #343
Conversation
Do not assume Console width in contributors machines (My situation: Win10 with console width=120)
|
This issue has caused problems for several. The other prblem is it works on your local but the build server does something different and causes the same tests to fail. Build server (appveyor) is using redirected output, so calls to GetWindowInfo throw an IOException when the sizing is being determined. The call stack doesnt help much, only telling the test that failed and not the specific method within the library thats initiating a call to Console.get_WindowHeight : https://ci.appveyor.com/project/commandlineparser/commandline/build/2.2.69-lipauiuy/job/xu37x7acde81g12p#L466 Another fellow reported that Docker seems to do similar as Appveyor, where the console output is probably redirected and would cause an IOException to be thrown. I'm just not sure what's generating that call to Console.get_WindowHeight. Searching for any "WindowHeight" strings in the project bring up literally nothing. |
moh-hassan
force-pushed
the
master
branch
2 times, most recently
from
5e09c7d to
182e72f
Compare
Do not assume Console width in contributors machines
(in my situation: Win10 with console width=120)
I fixed all failing tests: basically all tests with some option help-text's length higher than 80 (that are expected to be wrapped) but I think this should be done for all tests.