Skip to content

Add stack version requirement to stack.yaml #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snoyberg opened this issue Jun 1, 2015 · 4 comments
Closed

Add stack version requirement to stack.yaml #148

snoyberg opened this issue Jun 1, 2015 · 4 comments
Assignees
@snoyberg
Labels
need confirmation
Milestone
0.1.0.0

Comments

@snoyberg
Copy link
Contributor

snoyberg commented Jun 1, 2015

Motivation: a team could have a stack.yaml file in their project that would force the team to update. Ties in with #74
@snoyberg snoyberg modified the milestones: Second release, Third release Jun 1, 2015
@snoyberg snoyberg assigned borsboom and unassigned borsboom Jun 9, 2015
borsboom added a commit that referenced this issue Jun 11, 2015
@borsboom
Add stack version requirement to stack.yaml #148
1e1b365
@borsboom borsboom assigned snoyberg and unassigned borsboom Jun 11, 2015
@borsboom
Copy link
Contributor

@snoyberg confirmed?

@snoyberg
Copy link
Contributor Author

Two things:

  1. Can you add a description of this to https://github.com/commercialhaskell/stack/wiki/stack.yaml ?
  2. In the Monoid instance, instead of simply taking the latest version range, I'd recommend using intersectVersionRanges so that we get the requirements from all stack.yaml files being used. It may make sense to get rid of the Maybe wrapping and default to anyVersion in that case.

@snoyberg snoyberg assigned borsboom and unassigned snoyberg Jun 11, 2015
borsboom added a commit that referenced this issue Jun 11, 2015
@borsboom
Use intersectVersionRanges for requireStackVersion (#148)
d363bce
@borsboom
Copy link
Contributor

@snoyberg Alright, now it uses intersectVersionRanges. And this time I've pushed my change to stack.yaml.md.

@borsboom borsboom assigned snoyberg and unassigned borsboom Jun 11, 2015
@snoyberg
Copy link
Contributor Author

Awesome!

borsboom added a commit that referenced this issue Jun 11, 2015
@borsboom
Use 'simplifyVersionRange' on 'requireStackVersion' value for better …
88ca1f2 
…error message (#148)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snoyberg snoyberg

Labels
need confirmation
Projects
None yet
Milestone
0.1.0.0
Development

No branches or pull requests
2 participants
@snoyberg @borsboom