Skip to content

"Implicitly adding" messages are wrong #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snoyberg opened this issue Aug 31, 2017 · 1 comment
Closed

"Implicitly adding" messages are wrong #3398

snoyberg opened this issue Aug 31, 2017 · 1 comment

Comments

@snoyberg
Copy link
Contributor

I don't have details yet on exactly when this happens, but the simple statement is: we have messages coming from Stack now that say "implicit adding package ...." based on command line flags and the like. The heuristics to generate these messages are completely wrong. We can either fix them, or decide that there's no reason to have these messages and delete them. I'm open to input.

@snoyberg snoyberg added this to the P1: Must milestone Aug 31, 2017
@mgsloan
Copy link
Contributor

mgsloan commented Aug 31, 2017

I believe that happens when you pass --flag pkg:flagname and pkg is a snapshot package. I think the reason for the message is related to the old behavior described in #3374 , which is that a package needs to be listed in extra-deps in order to have a flag applied to it.

Now that the restriction removed, this message indeed doesn't make any sense. I can't think of any decisions the user would make based on it, so my vote is to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants