Fix Windows build #2482
Merged
Fix Windows build #2482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deduplicate code that I'll have to change to fix compilation on Windows (and maybe a few other things).
To this end, define WINDOWS also in testsuite.
Note the issue is not triggered on AppVeyor, but it is triggered when checking files out on Windows using recommended Git settings (Windows newlines). Workaround for nikita-volkov/neat-interpolation#14, no more necessary if that bug is fixed. This defines a variant of shouldBe; while at it, also integrate needed string type conversions.
|
Merged. I'd still welcome a code review, as there are quite a few non-obvious choices involved. But I'm uneasy with a broken build & rank fixing the build higher, lest other regressions slip in. |
|
LGTM, thanks for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the regressions from #2457.