Do correct path checking in precompiled cache. #3494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
The commit ed9ccc0 changed the behavior of the precompiled cache to store relative instead of absolute paths. That seems to have broken the ability to properly check if a library exists, thereby defeating precompiled caching. The issue that discovered this is #3431, and ascribed this to extensible snapshots. I _think_, though I'm not 100% certain, that this bug reaches much farther than extensible snapshots, and in fact breaks all precompiled caches.
snoyberg
force-pushed
the
3431-fix-precompiled-cache-checks
branch
from
94c3839 to
7b5bfbc
Compare
|
Thanks! I've added an integration test for this as well. Once I get the green from Travis, I'll merge. (Or if someone gets to it before me, that's great too.) |
|
One and a half laptops later, I can confirm this fixes the sharing issue in #3431. |
|
I'm seeing a regression on this — including on |
|
Yeah, integration test failing on master and 8.4.3 (the test needs stm updating to 2.4.5.0 and then it fails properly) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit ed9ccc0 changed the behavior
of the precompiled cache to store relative instead of absolute paths.
That seems to have broken the ability to properly check if a library
exists, thereby defeating precompiled caching.
The issue that discovered this is #3431, and ascribed this to extensible
snapshots. I think, though I'm not 100% certain, that this bug reaches
much farther than extensible snapshots, and in fact breaks all
precompiled caches.
Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!